-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table: fix the issue that the default value for BIT
column is wrong | tidb-test=pr/2426 (#57303)
#57358
table: fix the issue that the default value for BIT
column is wrong | tidb-test=pr/2426 (#57303)
#57358
Conversation
Signed-off-by: Yang Keao <[email protected]>
BIT
column is wrong | tidb-test=pr/2424 (#57303)BIT
column is wrong | tidb-test=pr/2426 (#57303)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57358 +/- ##
================================================
Coverage ? 58.9246%
================================================
Files ? 1784
Lines ? 661372
Branches ? 0
================================================
Hits ? 389711
Misses ? 248071
Partials ? 23590
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wjhuang2016, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #57303
What problem does this PR solve?
Issue Number: close #57301, close #57312
Problem Summary:
CREATE TABLE
statement didn't assert whether the default value forBIT
is valid.BIT
column is casted multiple times and may cause unexpected behavior.What changed and how does it work?
BIT
default value.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.