Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protocol: support query attribute since mysql 8.0.23 #55175
base: master
Are you sure you want to change the base?
protocol: support query attribute since mysql 8.0.23 #55175
Changes from all commits
92285cf
b4df1e6
3f7c090
5993b04
df6d253
03ee920
2d565ad
13471df
8347fe6
170fcbe
ac2851c
19f2ec8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How well does this handle the case when the data is somehow truncated? (e.g. only one of two bytes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there would be a panic caused by an out-of-bounds slice access here, which would lead to the disconnection of this session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to re-use some of the parameter handling code that is used for prepared statements? Basically query attributes and parameters are very similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they all internally call parseBinaryParams. Further code reuse is also possible, but it may require passing in more args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also set
SessionVars.QueryAttributes
in this branch? Or a statement cannot use related functions if it's executed throughCOM_EXECUTE
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think set
SessionVars.QueryAttributes
in this branch is a good idea since query attribute only 'works' inCOM_QUERY
. SessionVars.QueryAttributes has no other purpose beyond being used for related functions.