-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gomod: fix MinSafeTS might be set to MaxUint64 permanently (#47469) #47554
gomod: fix MinSafeTS might be set to MaxUint64 permanently (#47469) #47554
Conversation
Signed-off-by: husharp <[email protected]>
cda1ff4
to
608a278
Compare
client-go pr tikv/client-go#999 |
@@ -90,7 +90,7 @@ require ( | |||
github.com/stretchr/testify v1.8.0 | |||
github.com/tdakkota/asciicheck v0.1.1 | |||
github.com/tiancaiamao/appdash v0.0.0-20181126055449-889f96f722a2 | |||
github.com/tikv/client-go/v2 v2.0.4-0.20230912041415-9c163cc8574b | |||
github.com/tikv/client-go/v2 v2.0.4-0.20231121070837-c1041a4358a2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JmPotato The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #47554 +/- ##
================================================
Coverage ? 73.6594%
================================================
Files ? 1085
Lines ? 348930
Branches ? 0
================================================
Hits ? 257020
Misses ? 75440
Partials ? 16470 |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
now can close this pr |
6.5 updated by #48768 (files) |
This is an automated cherry-pick of #47469
Signed-off-by: husharp [email protected]<!--
Thank you for contributing to TiDB!
PR Title Format:
-->
What problem does this PR solve?
Issue Number: close #47468
Problem Summary:
What is changed and how it works?
The core question is getting safe ts in client-go
PD API
to not executego func which for KV request
, resulting in not updatingsafeTSMap
.updateMinSafeTS
relies onsafeTSMap
which makes sense(because actually, we can callupdateMinSafeTS
tokvReuqestUpdater
[to indicate func base]).minsafeTS
to make sure when API fails we can fall back to the original way which is by kv request.updateMinSafeTS
will returnmaxUnit64
when the first kv request returns 0 and then althoughPD API
returns correctly[maybe kv is not initialized], TS can not changemaxUnit64
.maxUnit64
as 0 which means there is an initial state.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.