Skip to content

Conversation

@handlerww
Copy link

@handlerww handlerww commented Nov 25, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

This PR adds a migration guide for Prometheus integration at the cluster level. The guide assists users in transitioning from legacy project-level Prometheus integrations to the new cluster-level integrations in TiDB Cloud. It outlines the necessary steps, prerequisites, and highlights the impact of deleting legacy integrations. Additionally, it provides support contact information for further assistance.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Nov 25, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @handlerww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides essential documentation to assist users in migrating their Prometheus monitoring setups in TiDB Cloud. It addresses the deprecation of project-level integrations by offering a clear path to adopt the more granular cluster-level approach, ensuring continuous and effective monitoring for TiDB Cloud users.

Highlights

  • New Migration Guide: This pull request introduces a comprehensive migration guide for users transitioning from legacy project-level Prometheus integrations to the new cluster-level integrations within TiDB Cloud.
  • Detailed Steps and Impact: The guide outlines necessary prerequisites, step-by-step instructions for deleting old integrations and creating new ones, and an impact statement detailing potential service disruptions during the migration process.
  • Documentation Update: A new document, 'Migrate Prometheus Integrations', has been added to the TiDB Cloud documentation, and the main table of contents has been updated to include a link to this new guide.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Nov 25, 2025
@pingcap-cla-assistant
Copy link

pingcap-cla-assistant bot commented Nov 25, 2025

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new migration guide for Prometheus integrations, helping users transition from the legacy project-level setup to the new cluster-level integrations. The changes are clear and well-structured. I've provided a few suggestions to improve consistency and clarity in the new documentation file, mainly regarding the use of plural for 'integrations' and phrasing around the deprecation date.

@handlerww handlerww force-pushed the handlerww/prom-integration-migration branch 2 times, most recently from 8ea26c2 to 0554dbc Compare November 25, 2025 10:41

# Migrate Prometheus Integrations

TiDB Cloud now manages Prometheus integrations at the cluster level, offering more granular control and configuration. The legacy project-level Prometheus integrations will be deprecated on December 31, 2025. If your organization is still using these legacy integrations, follow this guide to migrate to the new cluster-level Prometheus integrations to minimize disruptions to your metrics-related services.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update deprecated time: January 6, 2026.


4. In the displayed dialog, type `Delete` to confirm the removal of the legacy integration.

### Step 2. Create the new Prometheus integration for each cluster
Copy link

@huoyao1125 huoyao1125 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a new cluster-level Prometheus integration for each cluster


2. In the left navigation panel, click **Project Settings** > **Integrations**.

3. On the **Integrations** page, click **Delete** next to **Integration to Prometheus**.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Integrations > Integration to Prometheus(Beta) module, select Scrape_config Files and click Delete.


# Migrate Prometheus Integrations

TiDB Cloud now manages Prometheus integrations at the cluster level, offering more granular control and configuration. The legacy project-level Prometheus integrations will be deprecated on December 31, 2025. If your organization is still using these legacy integrations, follow this guide to migrate to the new cluster-level Prometheus integrations to minimize disruptions to your metrics-related services.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legacy project-level Prometheus integrations(Beta) will be deprecated on January 6, 2026.


## Migration steps

### Step 1. Delete the legacy project-level Prometheus integrations
Copy link

@huoyao1125 huoyao1125 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 1. Delete the legacy project-level Prometheus integrations (Beta)


Repeat the following steps for each [TiDB Cloud Dedicated](/tidb-cloud/select-cluster-tier.md#tidb-cloud-dedicated) cluster in the project.

1. In the [TiDB Cloud console](https://tidbcloud.com/), switch to the target cluster using the combo box in the upper-left corner.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In the TiDB Cloud console, navigate to the Clusters page of your project, and then click the name of your target cluster to go to its overview page.


## Impact statement

Deleting the project-level integration immediately stops all clusters in the project from exposing metrics to the Prometheus endpoint. This results in a temporary loss of downstream data and interrupts integration-related services (such as monitoring and alerts) until you configure the new cluster-level Prometheus integrations.
Copy link

@huoyao1125 huoyao1125 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting the project-level Prometheus integration (beta) immediately stops all clusters in the project from exposing metrics to the Prometheus endpoint.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 27, 2025

@huoyao1125: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd self-assigned this Nov 28, 2025
@hfxsd hfxsd self-requested a review November 28, 2025 08:35
@hfxsd hfxsd added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Nov 28, 2025

## Migration steps

### Step 1. Delete the legacy project-level Prometheus integrations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Step 1. Delete the legacy project-level Prometheus integrations
### Step 1. Delete the legacy project-level Prometheus integrations (Beta)

@handlerww handlerww force-pushed the handlerww/prom-integration-migration branch from eb03db7 to 9c4e4e9 Compare December 1, 2025 02:42
@handlerww handlerww force-pushed the handlerww/prom-integration-migration branch from 9c4e4e9 to bad8efa Compare December 1, 2025 03:09
@hfxsd hfxsd added the area/tidb-cloud This PR relates to the area of TiDB Cloud. label Dec 1, 2025
@lilin90 lilin90 added the for-cloud-release This PR is related to TiDB Cloud release. label Dec 1, 2025
@hfxsd hfxsd requested a review from qiancai December 1, 2025 07:48
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 1, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 1, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 1, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-01 09:35:05.546737762 +0000 UTC m=+256050.360515324: ☑️ agreed by qiancai.
  • 2025-12-01 10:48:08.952654136 +0000 UTC m=+260433.766431707: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Dec 2, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 2, 2025
@ti-chi-bot ti-chi-bot bot merged commit 0eff9aa into pingcap:release-8.5 Dec 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. for-cloud-release This PR is related to TiDB Cloud release. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants