Skip to content

sql: Add support for '(' literal ')' as column default#20539

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
mjonss:allow-default-leteral-parantheses
Nov 10, 2025
Merged

sql: Add support for '(' literal ')' as column default#20539
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
mjonss:allow-default-leteral-parantheses

Conversation

@mjonss
Copy link
Copy Markdown
Contributor

@mjonss mjonss commented Mar 14, 2025

What is changed, added or deleted? (Required)

Added support for '(' literal ')' as Column default, as added in pingcap/tidb#59023

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Mar 14, 2025
@mjonss mjonss requested a review from Defined2014 March 14, 2025 16:52
@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2025
@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2025
bb7133
bb7133 approved these changes Mar 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 14, 2025

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 15, 2025

@Defined2014: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Apr 14, 2025
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 14, 2025
@hfxsd hfxsd added the v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. label Apr 14, 2025
@hfxsd hfxsd mentioned this pull request Apr 14, 2025
Merged
16 tasks
@hfxsd hfxsd changed the title Add support for '(' literal ')' as column default sql: Add support for '(' literal ')' as column default Apr 14, 2025
@hfxsd hfxsd self-assigned this Apr 14, 2025
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed translation/doing This PR's assignee is translating this PR. labels Apr 14, 2025
@hfxsd hfxsd requested a review from lilin90 November 7, 2025 04:16
lilin90
lilin90 approved these changes Nov 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 10, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Nov 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-14 01:06:12.796771396 +0000 UTC m=+2650466.481007492: ☑️ agreed by hfxsd.
  • 2025-11-10 03:06:17.922104188 +0000 UTC m=+671427.365134057: ☑️ agreed by lilin90.

@hfxsd hfxsd removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2025
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Nov 10, 2025

/approve

@ti-chi-bot ti-chi-bot Bot added the approved label Nov 10, 2025
@hfxsd hfxsd closed this Nov 10, 2025
@hfxsd hfxsd reopened this Nov 10, 2025
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Nov 10, 2025

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Nov 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot merged commit 566befd into pingcap:master Nov 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@lilin90 lilin90 lilin90 approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees

@hfxsd hfxsd

Labels

approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mjonss @hfxsd @bb7133 @Defined2014 @lilin90