Add serivce account requirement for tiflash pod while restore #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
first-time-contributor
RidRisR
changed the title
ti-chi-bot
bot
added
the
size/XS
BornChanger
approved these changes
Nov 22, 2024
|
@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
csuzhangxc
reviewed
Nov 25, 2024
Co-authored-by: Xuecheng Zhang <[email protected]>
Co-authored-by: Xuecheng Zhang <[email protected]>
Oreoxmt
added
needs-cherry-pick-release-1.5
ti-chi-bot
bot
removed
the
missing-translation-status
Oreoxmt
reviewed
Nov 25, 2024
Co-authored-by: Aolin <[email protected]>
Co-authored-by: Aolin <[email protected]>
ti-chi-bot
bot
added
size/S
Oreoxmt
approved these changes
Nov 26, 2024
csuzhangxc
approved these changes
Nov 26, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
@Oreoxmt PTAL again |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
In response to a cherrypick label: new pull request created to branch |
7 tasks
|
In response to a cherrypick label: new pull request created to branch |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added, or deleted? (Required)
Which TiDB Operator version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?