Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: add more parameters #18521

Merged
merged 12 commits into from
Mar 27, 2025
Merged

ticdc: add more parameters #18521

merged 12 commits into from
Mar 27, 2025

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Sep 2, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

add more param description for MySQL sink url

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions))

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Sep 2, 2024
Copy link

ti-chi-bot bot commented Sep 2, 2024

Hi @wk989898. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2024
@CharlesCheung96
Copy link
Contributor

This pr need to be cheey-picked to LTS release version.

@hfxsd hfxsd self-assigned this Jan 23, 2025
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jan 23, 2025
@hfxsd hfxsd changed the title add doc for ticdc-sink-to-mysql ticdc: add more parameters Jan 23, 2025
@hfxsd hfxsd mentioned this pull request Jan 23, 2025
16 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 23, 2025
@lilin90 lilin90 added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Feb 6, 2025
Copy link

ti-chi-bot bot commented Mar 26, 2025

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MySQL sink URL documentation for TiCDC by adding more parameter descriptions and specifying additional limits and options.

  • Updated existing parameters (e.g., worker-count and max-txn-row) with maximum value limits.
  • Added new parameters including max-multi-update-row, batch-dml-enable, read-timeout, write-timeout, timeout, and tidb-txn-mode.
Comments suppressed due to low confidence (1)

ticdc/ticdc-sink-to-mysql.md:64

  • [nitpick] Consider changing '下游数据' to '下游数据库' for clarity and consistency.
| `3306`         | 下游数据的连接端口。                                 |

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 27, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 27, 2025
Copy link

ti-chi-bot bot commented Mar 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-27 08:02:07.351808028 +0000 UTC m=+1120221.036044124: ☑️ agreed by lilin90.
  • 2025-03-27 08:08:07.478051299 +0000 UTC m=+1120581.162287395: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Collaborator

hfxsd commented Mar 27, 2025

/approve

Copy link

ti-chi-bot bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 27, 2025
@ti-chi-bot ti-chi-bot bot merged commit 5908a80 into pingcap:master Mar 27, 2025
7 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 27, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20131.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20132.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 27, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Mar 27, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Mar 27, 2025
@lilin90 lilin90 added the ONCALL Relates to documentation oncall. label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants