Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: google vertex llm #599

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

jrj5423
Copy link
Collaborator

@jrj5423 jrj5423 commented Jan 16, 2025

Close #523.

Considering that our current llama_index can already support Vertex, should we merge ANTHROPIC_VERTEX into the same type as VERTEX in this commit?

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidb-ai-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 4:40am
tidb-ai-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 4:40am

Copy link

vercel bot commented Jan 16, 2025

@jrj5423 is attempting to deploy a commit to the pingcap Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@Mini256 Mini256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the ANTHROPIC_VERTEX for compatibility, we will delete it in the feature.

Please also support dsp.GoogleVertexAI on dspy LM

raise ValueError("Vertex is not supported by dspy.")

@@ -75,6 +75,22 @@ def get_llm(
credentials=google_creds,
**config,
)
case LLMProvider.VERTEX:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case LLMProvider.VERTEX:
case LLMProvider.ANTHROPIC_VERTEX:
case LLMProvider.VERTEX:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this suggestion mean to delete the processing operation of ANTHROPIC_VERTEX?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, merge it

@@ -132,6 +133,22 @@ class LLMProviderOption(BaseModel):
"private_key_id": "****",
},
),
LLMProviderOption(
Copy link
Member

@Mini256 Mini256 Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the provider name of ANTHROPIC_VERTEX option to Anthropic Vertex AI (Deprecated)

@@ -8,6 +8,7 @@ class LLMProvider(str, enum.Enum):
OPENAI = "openai"
GEMINI = "gemini"
ANTHROPIC_VERTEX = "anthropic_vertex"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the LLMProvider.ANTHROPIC_VERTEX enumeration to avoid errors for users who are already using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core(llm): support Google Vertex AI
2 participants