Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.33.0 to 2.35.0 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/hashicorp/terraform-plugin-sdk/v2](https://github.com/hashicorp/terraform-plugin-sdk) from 2.33.0 to 2.35.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-sdk/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-sdk/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-sdk@v2.33.0...v2.35.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-sdk/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
7 tasks
austin-denoble
added a commit
that referenced
this pull request
Apr 19, 2025
…ps (#39) ## Problem It has been a long while since we've updated the terraform provider, and the [go-pinecone](https://github.com/pinecone-io/go-pinecone) client the provider depends on has seen several major version bumps since then. There are a number of new index features the provider does not currently support: - Deletion protection - Index tags - Sparse / Dense indexes - Integrated inference There are also a number of other dependencies that could use updating, as dependabot has dutifully let us know: - #30 - #31 - #33 - #35 - #36 - #37 ## Solution - Bump go-pinecone to the latest version: v3.1.0 - Bump various dependencies around the terraform-plugin-framework and go (see the list above). - Update index resource and data source schemas to support new index configurations: `deletion_protection`, `tags`, `embed`, and `vector_type`. - Previously, the `IndexResource` `Update` method was basically a noop, this has now been updated to support updating index tags, deletion_protection, and embed properties. Check out the `Update` method in `index_resource.go` for specifics on how this is handled. - The `IndexResource` `Create` method also has a lot of changes to support creating various index types. - The schemas for both `IndexDataSource` and `IndexResource` have been updated to include all of the new index configuration fields. For context: in terraform a "resource" is the managed thing you're creating / updating, and a data source is a "read only" representation of that thing. - I've done an overhaul on how we're testing some things in `index_resource_test.go`, and a few other places. This was primarily to cover certain error cases and the full flow from create -> update -> destroy for indexes. - Collections are unchanged in this update. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [X] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan You'll need to install the terraform CLI locally. Easiest way is probably through brew: ```sh brew tap hashicorp/tap brew install hashicorp/tap/terraform terraform -version ``` After installing terraform, find your `~/.terraformrc` file, clone this repo, and add a dev override for wherever you've built the provider binary locally. It should look something like this: ``` provider_installation { dev_overrides { "pinecone-io/pinecone" = "/Users/austin/workspace/terraform-provider-pinecone" } # For all other providers, install them directly from their origin provider # registries as normal. If you omit this, Terraform will _only_ use # the dev_overrides block, and so no other providers will be available. direct {} } ``` Create a folder for testing the locally built provider from the cloned repo, and add a new hcl file (something like `main.tf`): ```sh mkdir pinecone-terraform-test cd pinecone-terraform-test touch main.tf ``` Update the `main.tf` file with your desired configuration. For example, here's a serverless integrated index: ```tf terraform { required_providers { pinecone = { source = "pinecone-io/pinecone" } } } provider "pinecone" { } resource "pinecone_index" "testsls" { name = "tftestslsindex22" deletion_protection = "disabled" metric = "cosine" spec = { serverless = { cloud = "aws" region = "us-west-2" } } tags = { test = "test1" blah = "foo" } embed = { model = "multilingual-e5-large" field_map = { text = "chunk_text" } } } ``` Once you've updated your `main.tf` file, you can run the following: ```sh # generally only need to init the first time with a new tf file terraform init # plan will give you a preview of the resource you're about to create or update terraform plan # apply will actually create or update the thing terraform apply ``` From there you can make changes to the resource, or add new resources to the configuration file and rerun `terraform plan / terraform apply`. Use the Pinecone console to validate the external resource is created and updated as expected. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208748187516169
|
implemented in: #39 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/go_modules/github.com/hashicorp/terraform-plugin-sdk/v2-2.35.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/hashicorp/terraform-plugin-sdk/v2 from 2.33.0 to 2.35.0.
Release notes
Sourced from github.com/hashicorp/terraform-plugin-sdk/v2's releases.
Changelog
Sourced from github.com/hashicorp/terraform-plugin-sdk/v2's changelog.
Commits
da29621Update changelog0569613Update meta package SDKVersion23a11cfall: Initial ephemeral resource implementation (#1390)24fa92abuild(deps): bump github.com/hashicorp/terraform-json (#1388)0875f54build(deps): bump github.com/hashicorp/terraform-plugin-go (#1389)64f0922Result of tsccr-helper -log-level=info gha update -latest . (#1387)71a8bdeResult of tsccr-helper -log-level=info gha update -latest . (#1385)dd6c100Result of tsccr-helper -log-level=info gha update -latest . (#1381)5efee53build(deps): bump golang.org/x/crypto from 0.27.0 to 0.28.0 (#1382)b454e07Fix typos (#1380)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)