-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for embedded objects #328
base: develop
Are you sure you want to change the base?
Conversation
Is there any issue with testing nullable boolean |
Thanks for your contribution! I'll look into it as soon as possible. |
@vitusortner sorry for unnecessary commits, checkout the new clarified commits. |
Rebasing develop branch to get the latest commit #327 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some questions. Thanks for your initiative in starting this non-trivial task!
Thanks, @vitusortner for catching gaps, I'll try to follow the suggestions and also provide better testing. |
Resolved with 292cfb4, will update |
- Use prefix in field_processor for prefixing embedded columns. - Use StringBuffer instead of List<String> for building the constructor on queryable_processor for more clarity . - Add embedded_processor_test for testing embeddings.
Codecov Report
@@ Coverage Diff @@
## develop #328 +/- ##
===========================================
- Coverage 81.51% 81.25% -0.26%
===========================================
Files 59 63 +4
Lines 1509 1590 +81
===========================================
+ Hits 1230 1292 +62
- Misses 279 298 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
- Add boolean extension for parsing nullable fields. - Add Fieldable abstract class for both (Field, Embedded). - Passing null in constructor when field is ignore. - Fix nullable boolean field test case. - Some improvement and code enhancement.
@hsul4n Will this feature reach the final point? |
@hsul4n |
@hsul4n |
@hsul4n @vitusortner I'm really looking forward to this feature - Floor is exactly what I was looking for in an ORM package, and this is the missing piece that I need. Thank you guys for all of the hard work! Is there a rough idea of when it will be completed? |
Any news on embedded & relation features? |
@hsul4n @vitusortner any updates on this? It's been about 6 months since I last asked, and it seems to have died... Looks like no changes since 30 July 2020? |
any updates? |
@marcosmko I'd be willing to pitch in, too. I'll need to poke through the code to get an idea if how it all works |
@marcosmko, @amkuchta anything I can help you with? This PR has a bunch of conflicts by now but it might still help to get an idea of how to implement the feature. Thanks for your support 🙏 |
Hello @vitusortner, @amkuchta and @hsul4n, I synced this branch and created #538, but I still need to fix some things that got broken. |
Hi, whats status after all those years? I need embedded objects |
Here's an implementation for
@Embedded
annotation with test and example.Closing #9