Skip to content

Conversation

@cgonzalezbermudez
Copy link

as pimcore (platform-version v2024.4) is compatible with php 8.3 and 8.4, an issue is appearing with the message
Deprecated: Creation of dynamic property Pimcore\Model\User\Workspace\Asset::$path is deprecated in /var/www/html/vendor/pimcore/admin-ui-classic-bundle/src/Controller/Admin/UserController.php on line 713
and blocking the capacity to modify roles with has paths definitions in the workspaces

@github-actions
Copy link

github-actions bot commented May 28, 2025

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (cgonzalezbermudez)[https://github.com/cgonzalezbermudez]
@carlosgonzalezpdn
You can retrigger this bot by commenting recheck in this Pull Request

@cgonzalezbermudez
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Major Issues (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)
11 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@kingjia90
Copy link
Contributor

recheck

@fashxp
Copy link
Member

fashxp commented Aug 21, 2025

@carlosgonzalezpdn it seems that in that PR are now commits which don't belong to that PR?
could you please double check and have a look. Thx

@kingjia90 kingjia90 added the Bug label Aug 28, 2025
@kingjia90
Copy link
Contributor

kingjia90 commented Aug 28, 2025

Closing due to inactivity, branch basing and CLA issues

@kingjia90 kingjia90 closed this Aug 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2025
@kingjia90
Copy link
Contributor

kingjia90 commented Aug 28, 2025

In the meanwhile, i've provided an alternative on #986 that avoids the refactor of path to cpath in js.
$workspace->path is not used right after being created, so should be just fine

@pimcore pimcore unlocked this conversation Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants