Skip to content

Conversation

@arsengoian
Copy link
Contributor

Hi! I just added coverage for Facebook Broadcasts API (sending messages to groups of users) and labeling, according to documentation.

Broadcast reach evaluation and some minor features were not implemented.

Tests with complete coverage for the new features are included in PR.

MAIN DOC

TARGETING BROADCASTS DOC

@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #174   +/-   ##
=========================================
  Coverage     15.78%   15.78%           
  Complexity      190      190           
=========================================
  Files            23       23           
  Lines           646      646           
=========================================
  Hits            102      102           
  Misses          544      544
Impacted Files Coverage Δ Complexity Δ
FbBotApp.php 0% <ø> (ø) 46 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f8c56...dc6498a. Read the comment docs.

@arsengoian
Copy link
Contributor Author

Oops I didn't see the tests coming. I think tests should be moved to a different namespace, right?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.78%. Comparing base (67f8c56) to head (dc6498a).
Report is 8 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #174   +/-   ##
=========================================
  Coverage     15.78%   15.78%           
  Complexity      190      190           
=========================================
  Files            23       23           
  Lines           646      646           
=========================================
  Hits            102      102           
  Misses          544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants