-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: replace is-promise
dependency with instanceof
check
#137
base: master
Are you sure you want to change the base?
Conversation
This PR should likely not be merged until the next major. |
Just ping me whenever a new major is in the works and I will take a moment to rebase the work here. |
Really sorry to have left this one hanging for so long. You are right this is a breaking chance since it would drop support for some of the legacy promise forms that package supports. And looking back at the timing we had already cut the 2.x release line by the time this was opened anyway. So, what can we do? I think the best option we could do is to check if it is anything other than a native |
Sure, I can go ahead and make a PR that logs a deprecation for this. Do you have any examples of how deprecations should be logged that I could use as inspiration? |
We have used |
I like the idea of showing that warning |
Created a PR to add the message under #154 |
BREAKING: drops support for non-native promises Closes pillarjs#136 Signed-off-by: Jon Koops <[email protected]>
0508c6a
to
f38d8c9
Compare
Replaces the
is-promise
dependency with aninstanceof Promise
check.BREAKING: drops support for non-native promises
Closes #136