-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry2nix #533
Open
goodboy
wants to merge
9
commits into
master
Choose a base branch
from
poetry2nix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Poetry2nix #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Means commenting out the `data.cli.ingest()` as it will be deleted in the up coming #486 anyway.
NB: for now this is linking to a presumed local clone of the `poetry2nix` repo since part of fixing what was adjusted here needs to be patched upstream, which means hackin on the p2n repo in tandem B) Since there's some dependency build issues we need to tweak the following to get baseline `nix develop` working: - drop `python-levenshtein` (required by `fuzzywuzzy[speedup]`) for now since the overlay and/or wheel install needs to be properly figured out. - build `pyqt5` from src for the moment (since `preferWheel` doesn't seem to be workin?) despite it taking forever XD - add in the `flake.lock` file.
NB: for now this is linking to a presumed local clone of the `poetry2nix` repo since part of fixing what was adjusted here needs to be patched upstream, which means hackin on the p2n repo in tandem B) Since there's some dependency build issues we need to tweak the following to get baseline `nix develop` working: - drop `python-levenshtein` (required by `fuzzywuzzy[speedup]`) for now since the overlay and/or wheel install needs to be properly figured out. - build `pyqt5` from src for the moment (since `preferWheel` doesn't seem to be workin?) despite it taking forever XD - add in the `flake.lock` file.
Makes it easier to pass the overrides to multiple p2n functions (like hopefully `.mkPoetryEnv`). Also, add some commented attempts at using `mkPoetryEnv` and todo list for "why", remove the `poetry` CLI main point from the pyproject.toml, bump the poetry lock file.
Since we eventually want to allow users to minimally deploy `pikerd` service-tree (aka distributed cross host) installs, we need to offer a "headless" deps group. Really this is just the core dep set minus Qt and some aux search related libs (for now). The new `.dev` group is for adding hacking and testing tools including `xonsh` since that will eventually be our REPL of choice more then likely B) Oh, and fix the namespace path (was a typo) for the `ledger` CLI and of course bump the lock file.
Sup all, I think this is finally nearly ready for testing and reviewing! So far there's still no I will be updating the readme and adding a proper todo list before merge to the description above 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft hopefully getting
poetry
pkging andpoetry2nix
support working!