Skip to content

Commit

Permalink
Go back to caching on all curves
Browse files Browse the repository at this point in the history
Despite there being artifacts when interacting, the speedups when
cross-hair-ing are just too good to ignore. We can always play with
disabling caches when interaction takes place much like we do with feed
pausing.
  • Loading branch information
goodboy committed Feb 9, 2023
1 parent 9fa85b7 commit 3c4031e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions piker/ui/_curve.py
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ class FlattenedOHLC(Curve):
# avoids strange dragging/smearing artifacts when panning
# as well as mouse over artefacts when the vlm chart series
# is "shorter" then some overlay..
cache_mode: int = QGraphicsItem.NoCache
# cache_mode: int = QGraphicsItem.NoCache

def draw_last_datum(
self,
Expand Down Expand Up @@ -440,7 +440,7 @@ class StepCurve(Curve):
# avoids strange dragging/smearing artifacts when panning
# as well as mouse over artefacts when the vlm chart series
# is "shorter" then some overlay..
cache_mode: int = QGraphicsItem.NoCache
# cache_mode: int = QGraphicsItem.NoCache

def declare_paintables(
self,
Expand Down
2 changes: 1 addition & 1 deletion piker/ui/_ohlc.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class BarItems(FlowGraphic):
'''
# XXX: causes this weird jitter bug when click-drag panning
# where the path curve will awkwardly flicker back and forth?
cache_mode: int = QGraphicsItem.NoCache
# cache_mode: int = QGraphicsItem.NoCache

def __init__(
self,
Expand Down

0 comments on commit 3c4031e

Please sign in to comment.