Template all Findable trait functions #683
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make all of us out there using PHPstan at max level happy, and provide the correct return types to all
Findablefunctions!For easy review: the file to check is at https://github.com/picqer/exact-php-client/pull/683/files#diff-866469e983d1b8abc730b4cb257101d62275a08e5936fd40fcc7bdbeb2225acc
The other 426 changed files are mass find/replace of the same thing 😆
I've tested the change on a huge project in which we were ignoring over 40 errors caused by typing issues, all disappeared, and caused a few new ones from now obsolete type checks (this is irrelevant for B/C purposes as it only affects projects at level max which already have the other issue here and there's no runtime code).
Please do check that I didn't miss any
T|nullcases or anything.