Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use main branch from calibreapp/image-actions and run on schedule #1144

Open
wants to merge 2 commits into
base: release/v6.0
Choose a base branch
from

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Use main branch from calibreapp/image-actions as it contains updates compared to their latest, outdated tagged version

Ref:
https://github.com/calibreapp/image-actions?tab=readme-ov-file#-usage
https://github.com/calibreapp/image-actions/tags


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 6b43632
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/675ffb9ad074160008ea3242
😎 Deploy Preview https://deploy-preview-1144--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yubiuser
Copy link
Member Author

Some day there might be a new release: calibreapp/image-actions#283

@yubiuser
Copy link
Member Author

Do we want to run this on all PRs or keep the current behaviour?

paths:
- '**.jpg'
- '**.jpeg'
- '**.png'
- '**.webp'

We might be able to re-compress existing images if the action changes their compression algortihm.

@yubiuser yubiuser changed the title Use main branch from calibreapp/image-actions Use main branch from calibreapp/image-actions and run on schedule Dec 16, 2024
@yubiuser
Copy link
Member Author

I added a commit following their example (https://github.com/calibreapp/image-actions?tab=readme-ov-file#combined-workflow) to run this on schedule and open a PR if needed. I only changed the action used to create the PR, omitting peter-evans and using gh cli tool instead. We already use this in the other repos
https://github.com/pi-hole/web/blob/5c8945c81c98f6f17e5c138ffbfdcb0831e5a062/.github/workflows/sync-back-to-dev.yml#L16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant