sky_view_factor package added #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grufoony
requested changes
May 15, 2025
There was a problem hiding this comment.
Here I leave some final considerations:
- Standalone script with his data/output should not go into the package dir. We can think about a example folder which could be also useful as test (comparing input and output).
- Missing
__init__.pyfile which is used to init the submodule - Some files have a weird author... if they come from another repo, we could simply link them
- Consider to use
loggingmodule to print runtime informations andtqdmto show feedback on loops
| import numpy as np | ||
|
|
||
| def create_patches(patch_option): | ||
|
|
| @@ -0,0 +1,94 @@ | |||
| __author__ = 'xlinfr' | |||
There was a problem hiding this comment.
Does this code come from another repo?
|
|
||
| # Slope and aspect used in SEBE and Wall aspect | ||
| def get_ders(dsm, scale): | ||
| # dem,_,_=read_dem_grid(dem_file) |
There was a problem hiding this comment.
Docstring (same for all the functions in this file)
| return shadowresult | ||
|
|
||
|
|
||
| def shadowingfunction_20_old(a, vegdem, vegdem2, azimuth, altitude, scale, amaxvalue, bush, dlg, forsvf): |
There was a problem hiding this comment.
Does old mean deprecated?
| import wallalgorithms as wa | ||
|
|
||
| def wallscheme_prepare(dsm, scale, pixel_resolution, feedback): | ||
| total = 100. / (int(dsm.shape[0] * dsm.shape[1])) |
| loop_range = np.arange(svf_height, maxWallHeight + svf_height, svf_height) | ||
|
|
||
| # Loop for svf calculations of all voxel heights | ||
| for i in loop_range: |
There was a problem hiding this comment.
Why use feedback variable and not tqdm library?
| from osgeo.gdalconst import * | ||
|
|
||
| def annulus_weight(altitude, aziinterval): | ||
| n = 90. |
| @@ -0,0 +1,197 @@ | |||
| from builtins import range | |||
| # -*- coding: utf-8 -*- | |||
| __author__ = 'xlinfr' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.