Revert #441: #526
Open
Revert #441: #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Mar 17, 2021
Contributor
Author
|
Ouch, we would need to declare PHPSpec compatible with Prophecy 2.0 in advance 😢 I'll revert the |
Member
|
If we're going to bump the version number we should re-think the behaviour more comprehensively What do you think of #528 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472, declares a new major bump to 2.0.
As suggested by @stof in #472 (comment), this is an attempt to revert #441 and go back to the old behavior, with a fast bailout when the prophecy hits an unregistered method call.
This avoids returning
nullin those cases, since it would probably lead to\TypeErrors or other unpredictable behaviours, as originally pointed out in https://github.com/phpspec/prophecy/pull/441/files#r388191626.