Composer: raise the minimum supported version of Prophecy #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prophecy 1.3 was released in 2014, while Prophecy 1.10.0 - the last minor which still allows installation on PHP 5.3 -, was released in 2019. It seems prudent to raise the minimum supported version, if for no other reason than to ensure PHP cross-version compatibility. Ref: https://github.com/phpspec/prophecy/blob/master/CHANGES.md
jrfnl
force-pushed
the
feature/composer-raise-version-constraints
branch
from
2138059 to
4ef6ec5
Compare
|
Rebased after merge of #35 and marked ready for review. |
|
Looks outdated now, after the merge of PR for phpunit 10 support, 3 weeks ago |
Gosh, such a surprise if a PR is left to rot for 18 months... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prophecy 1.3 was released in 2014, while Prophecy 1.10.0 - the last minor which still allows installation on PHP 5.3 -, was released in 2019.
It seems prudent to raise the minimum supported version, if for no other reason than to ensure PHP cross-version compatibility.
Ref: https://github.com/phpspec/prophecy/blob/master/CHANGES.md