Fix to avoid scanning the current directory for composer.json #528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
By default, it recursively scans the current directory for composer.json and composer.lock.
When "files" are specified in the configuration, the scan should start from those directories, but it was also scanning the current directory.
This behavior has been fixed to scan from the specified directories when files are defined, and from the current directory when they are not.
Related issues: #463 #510
Result
.phpmetrics.json
{ "includes": [ "app" ], "exclude": [ "tests", "vendor", "docker" ], "report": { "html": "./tmp/php-metrics/report/", "csv": "./tmp/php-metrics/report.csv", "json": "./tmp/php-metrics/report.json", "violations": "./tmp/php-metrics/violations.xml" } }Before Fix
% ./vendor/bin/phpmetrics --config=./.phpmetrics.json Executing system analyzes... Executing composer analyzes, requesting https://packagist.org...PHP Fatal error: Uncaught UnexpectedValueException: RecursiveDirectoryIterator::__construct(./docker): Failed to open directory: Permission denied in ...After Fix
% ./vendor/bin/phpmetrics --config=./.phpmetrics.json Executing system analyzes... Executing composer analyzes, requesting https://packagist.org... LOC Lines of code 8 Logical lines of code 8 Comment lines of code 0 Average volume 0 Average comment weight 0 Average intelligent content 0 Logical lines of code by class 8 Logical lines of code by method 8 ... Done