chore: move the obtaining the version method to a separate class

[godruoyi]

No description provided.

[asgrim]

Thanks @godruoyi !

[TimWolla]

This is a dead reference, because Application is not imported here.

[asgrim]

Hah, good spot - indeed it's not fully qualified, but PhpStorm doesn't seem to mind, I'd actually checked I could click through, so missed it wasn't fully qualified

[godruoyi]

Thank guys for your suggestions. I'll update them in next PR. And I have a question why we need to define a variable here? for me understand is this always true right? should we delete it directly?

    public static function get(): string
    {
        $pieVersion = '@pie_version@';

        if ($pieVersion === '@pie_version' . '@') {
            // always be true
        }
    }

[asgrim]

@godruoyi I actually added a comment to the class in your PR:

pie/src/Util/PieVersion.php

Lines 29 to 41 in 75dbc22

	/**
	* This value is replaced dynamically by Box with the real version when
	* we build the PHAR. It is based on the Git tag and/or version
	*
	* It will be replaced with `2.0.0` on an exact tag match, or something
	* like `2.0.0@e558e33` on a commit following a tag.
	*
	* When running not in a PHAR, this will not be replaced, so this
	* method needs additional logic to determine the version.
	*
	* @link https://box-project.github.io/box/configuration/#pretty-git-tag-placeholder-git
	*/
	$pieVersion = '@pie_version@';