-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for os-families-exclude
in extensions composer.json
#116
Conversation
93521d0
to
16b8734
Compare
os-families
in extensions composer.json
os-families-exclude
in extensions composer.json
a303ebf
to
71003c8
Compare
51387f8
to
0c2998a
Compare
Revamped the whole PR to address your comments.
|
0c2998a
to
69bed8b
Compare
69bed8b
to
cc4cdf8
Compare
This is great, love to exclude windows. |
cc4cdf8
to
2926ac4
Compare
… `composer.json`
2926ac4
to
f934832
Compare
Remaining CS warnings should be fixed once composer/composer#12218 is merged |
03d24dc
to
afdcbab
Compare
PR composer/composer#12218 is now merged; please can you update the composer req, that should fix the static analysis |
afdcbab
to
1fd01f0
Compare
1fd01f0
to
8110e8c
Compare
Here you go, all green! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexandre-daubois
It's now tagged as part of composer 2.8.4 |
Thanks @Seldaek ! |
Fix #106
Allows to specify OS families which the extension is incompatible with:
When the syntax is validated, I'll create a PR in Composer to allow the new key in the
Package::$phpExt
property.Related to ThePHPF/pie-design#29