Don't use NTS for returned values via env attr #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User issue on IBM i may involve the driver not returning properly null terminating strings correctly. The get_col handler seems to handle this case, so let's do a CI run to see how badly this explodes on LUW.
I think this is Informix detritus anyways - there's a dedicated PDO driver for that, so maybe we should be cleaning this up...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User issue on IBM i may (not necessarily) involve the driver not null terminating strings correctly. The get_col handler seems to handle this case, so let's do a CI run to see how badly this explodes on LUW. This is definitely not the right solution, but I'm curious to see how it gets handled in code paths.