Add support for PhpParser v5 for PHP 7.4+ #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
nikic/php-parser
v5 for PHP 7.4+, while retaining compatibility with v4 for PHP 7.3.Key Changes
parts
property ofPhpParser\Node\Name
was deprecated in v4 and removed in v5. It has been replaced with a call togetFirst()
, which is available in both major versions.create()
method and thePREFER_PHP7
constant were removed fromPhpParser\ParserFactory
in v5. This PR uses thecreateForNewestSupportedVersion()
method instead, which is available in both v4 and v5. According to the upgrade guide, this method is "roughly equivalent to PREFER_PHP7 behavior".Testing
The changes were tested with
php-stubs/wordpress
. Output under v5 (5.4.0) differs slightly but improves correctness:final
and visibility modifiers.Closes #25
Closes #31