Fix release workflow reusable permissions - #16
Merged
Ryan Zhu (underthestars-zhy) merged 1 commit intoJul 21, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🔇 Additional comments (1)
📝 WalkthroughWalkthroughThe release workflow’s job permissions now include ChangesRelease workflow permissions
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages: writeto the BuildSpace reusable release workflowRoot cause
GitHub validates nested reusable-workflow permissions before evaluating job conditions. BuildSpace's new
github-packages-publishjob requestspackages: write, but this caller previously allowed onlypackages: none, so the Release workflow failed at startup without creating any jobs.Validation
git diff --checkbun x ultracite check(passes with the repository's existing broken-symlink warning)Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Note
Low Risk
CI-only permission change with no application or data-handling impact.
Overview
Fixes Release workflow startup failures by granting
packages: writeon the job that calls BuildSpace’s reusabletypescript-service-release.yaml.GitHub checks nested reusable-workflow job permissions before job
ifconditions run. The reusable workflow’sgithub-packages-publishjob needspackages: write, but the caller previously did not pass that through, so the workflow failed before any jobs ran—even when GitHub Packages publishing was skipped.A short comment in
release.yamldocuments why this permission is required despite optional publishing.Reviewed by Cursor Bugbot for commit dbe21b9. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit