claude ingest: tolerate a null file_name in the export - #1
Merged
Conversation
A Claude.ai export can carry a files/attachments entry whose file_name
key is present but explicitly null (a file shared without a name).
`dict.get("file_name", "?")` only substitutes the default for a *missing*
key, so the null flowed into `", ".join(files)` and crashed the whole
ingest with `TypeError: sequence item 0: expected str instance, NoneType
found`. Fall back with `or "?"` so the placeholder is still produced.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Improves robustness of the Claude.ai export ingester by preventing a crash when a shared file/attachment has an explicitly null file_name in the export payload.
Changes:
- Handle
file_name: nullby falling back to"?"so", ".join(files)always receives strings. - Add inline rationale explaining why
.get("file_name", "?")was insufficient for explicit nulls.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Claude.ai export can carry a files/attachments entry whose file_name key is present but explicitly null (a file shared without a name).
dict.get("file_name", "?")only substitutes the default for a missing key, so the null flowed into", ".join(files)and crashed the whole ingest withTypeError: sequence item 0: expected str instance, NoneType found. Fall back withor "?"so the placeholder is still produced.