Worktree immich 203 - #29
Merged
Merged
Conversation
added 2 commits
July 13, 2026 16:57
Contributor
There was a problem hiding this comment.
Pull request overview
Adds SMART disk health metrics to the existing observability-sender stack by enabling the smartctl Prometheus exporter and wiring it into the Alloy → Mimir remote_write pipeline.
Changes:
- Simplifies node_exporter enablement to a direct option assignment.
- Enables the smartctl Prometheus exporter for SMART disk metrics on observability-sender hosts.
- Adds an Alloy
prometheus.scrapejob to actually ingest smartctl exporter metrics into Mimir.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # node_exporter fail on an unknown --collector.smartctl flag. It only | ||
| # yields data on hosts whose disks actually expose SMART; plain virtio | ||
| # disks in VMs don't, so expect empty results there. | ||
| services.prometheus.exporters.smartctl.enable = true; |
Comment on lines
+524
to
+528
| prometheus.scrape "smartctl" { | ||
| targets = [{"__address__" = "127.0.0.1:9633"}] | ||
| job_name = "integrations/smartctl" | ||
| forward_to = [prometheus.remote_write.nixvms.receiver] | ||
| } |
Comment on lines
+482
to
+486
| # SMART disk metrics. smartctl is its own exporter (:9633), NOT a | ||
| # node_exporter collector — passing it via enabledCollectors makes | ||
| # node_exporter fail on an unknown --collector.smartctl flag. It only | ||
| # yields data on hosts whose disks actually expose SMART; plain virtio | ||
| # disks in VMs don't, so expect empty results there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.