Scope jellyfin's private-share ACL to a dedicated clips folder - #26
Merged
Conversation
Jellyfin previously had recursive read+execute over the entire private share, but Jellyfin is the only public, unauthenticated-at-the-edge service on this host. Narrow its filesystem access to a single clips/ subfolder: traverse-only on the private root, full rX only on clips.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens filesystem permissions on host 203-media by narrowing Jellyfin’s ACL access within the private Samba share to a dedicated clips/ subfolder, reducing exposure for a publicly reachable service.
Changes:
- Create
/mnt/Shares/.../clipsviasystemd.tmpfilesto ensure the target directory exists with consistent ownership/mode. - Replace the previous recursive Jellyfin ACL on the whole private share with separate ACLs intended to provide traverse-only on the private root and read+execute on
clips/.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # already knows but can't list the root's contents -- and full | ||
| # read+execute only on clips itself. A+ recurses over existing content; | ||
| # the `d:` default entry on clips handles anything written there later. | ||
| "A+ /mnt/Shares/this-is-my-own-private-property-and-you-are-not-welcome-here - - - - u:jellyfin:x" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jellyfin previously had recursive read+execute over the entire private share, but Jellyfin is the only public, unauthenticated-at-the-edge service on this host. Narrow its filesystem access to a single clips/ subfolder: traverse-only on the private root, full rX only on clips.