fix darwin rebuild - #22
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix macOS (nix-darwin) rebuilds by adjusting Home Manager configuration to avoid a failing assertion, and updates flake inputs to newer revisions.
Changes:
- Disable
programs.fzf.enableNushellIntegrationinmodules/shell.nixto avoid the Home Manager assertion that requires a newerfzfthan what the pinned nixpkgs provides. - Adjust
yt-dlppackaging in the desktop Home Manager modules (remove the custom override and add plainyt-dlp). - Update
flake.lockinputs (notablyhome-manager,nix-darwin, and others) and simplify some input indirections.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/shell.nix | Disables fzf Nushell integration to avoid HM’s fzf version assertion during darwin rebuilds. |
| modules/desktop.nix | Removes yt-dlp override usage and adds yt-dlp plainly to the nixos-specific home packages list. |
| flake.lock | Updates pinned flake inputs and cleans up/simplifies some input references. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.