Skip to content

Conversation

HenrikEngen
Copy link
Member

No description provided.

@HenrikEngen HenrikEngen requested a review from petterroea August 25, 2025 18:44
@HenrikEngen HenrikEngen self-assigned this Aug 25, 2025
@HenrikEngen HenrikEngen added the enhancement New feature or request label Aug 25, 2025
@HenrikEngen HenrikEngen marked this pull request as draft August 25, 2025 18:44
op.create_foreign_key(op.f('fk_position_event_type_uuid_event_type'), 'position', 'event_type', ['event_type_uuid'], ['uuid'])
op.add_column('seatmap', sa.Column('event_type_uuid', sa.UUID(), nullable=True))
op.create_foreign_key(op.f('fk_seatmap_event_type_uuid_event_type'), 'seatmap', 'event_type', ['event_type_uuid'], ['uuid'])
op.add_column('seatmap_background', sa.Column('event_type_uuid', sa.UUID(), nullable=True))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is nullable true? are we planning to support shared seatmap backgrounds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, but as everything else in this revision, we need to start with setting nullable to True, and insert an initial event brand uuid before we can set it to false?

class EventType(Base):
__tablename__ = "event_type"

uuid = Column(UUID(as_uuid=True), primary_key=True, default=uuid.uuid4, unique=True, nullable=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we agreed to use a string instead of uuid here, since people will need to know/remember it when configuring clients?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so like a slug instead of uuid? (which is a string which we enforce to be lowercase letters and -_ or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants