-
Notifications
You must be signed in to change notification settings - Fork 0
Multitenant feature #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
61d9f4c
to
c7e2f78
Compare
…dded event_type_uuid to tables that should use this, added can_checkin column to ticket_type table
op.create_foreign_key(op.f('fk_position_event_type_uuid_event_type'), 'position', 'event_type', ['event_type_uuid'], ['uuid']) | ||
op.add_column('seatmap', sa.Column('event_type_uuid', sa.UUID(), nullable=True)) | ||
op.create_foreign_key(op.f('fk_seatmap_event_type_uuid_event_type'), 'seatmap', 'event_type', ['event_type_uuid'], ['uuid']) | ||
op.add_column('seatmap_background', sa.Column('event_type_uuid', sa.UUID(), nullable=True)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is nullable true? are we planning to support shared seatmap backgrounds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, but as everything else in this revision, we need to start with setting nullable to True, and insert an initial event brand uuid before we can set it to false?
class EventType(Base): | ||
__tablename__ = "event_type" | ||
|
||
uuid = Column(UUID(as_uuid=True), primary_key=True, default=uuid.uuid4, unique=True, nullable=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we agreed to use a string instead of uuid here, since people will need to know/remember it when configuring clients?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so like a slug
instead of uuid? (which is a string which we enforce to be lowercase letters and -_
or something?
No description provided.