Adds mounts to fly backend (yep, the third one) #81
+163
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had a sudden need for adding mounts to Fly FLAME servers to shift infrequent long running CPU intensive data exports off our main app machines and into the background where they won't bother anybody. So I'm picking up the torch for this work.
To achive this i've initially forked from #22 to maintain @benbot's commit credit as they did the initial heavy lifting for this work. I've then updated to the latest resolving all merge conflicts, which then didn't compile as the way http requests are made has changed.
My contribution to this PR is resolving the compile errors and then making a bunch of improvements to add resilience:
Note: we currently have this running on a QA server without issue and I plan future work to allow creating volumes if none are available to limit the number of big volumes hanging around unused