Skip to content

usb: Notify apps about usb device insertion #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamgreloch merged 11 commits into from
May 15, 2025
Merged

usb: Notify apps about usb device insertion #36

adamgreloch merged 11 commits into from
May 15, 2025

Conversation

@adamgreloch
Copy link
Member

@adamgreloch adamgreloch commented Apr 3, 2025 •
edited
Loading

JIRA: RTOS-1024

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • usb_insertion_handler_t signature has changed
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1024 branch from 879b75b to a00d89e Compare April 4, 2025 08:50
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-970 branch from ce9f923 to 3d4143b Compare April 4, 2025 16:13
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1024 branch from 16177ea to 9d391fe Compare April 4, 2025 16:14
@adamgreloch adamgreloch requested a review from Darchiv April 8, 2025 10:11
@adamgreloch adamgreloch marked this pull request as ready for review April 8, 2025 10:11
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1024 branch 2 times, most recently from 7db3e6c to 331ac30 Compare April 10, 2025 13:57
@adamgreloch adamgreloch mentioned this pull request Apr 10, 2025
Merged
14 tasks
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-970 branch from 3d4143b to b86226b Compare April 15, 2025 09:28
Base automatically changed from adamgreloch/RTOS-970 to master April 15, 2025 09:37
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1024 branch from 331ac30 to 7cae328 Compare April 15, 2025 10:08
@github-actions
Copy link

github-actions bot commented Apr 15, 2025 •
edited
Loading

Unit Test Results

7 958 tests   7 434 ✅  42m 42s ⏱️
  470 suites    524 💤
    1 files        0 ❌

Results for commit d8e07db.

♻️ This comment has been updated with latest results.

@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1024 branch 3 times, most recently from 2858d50 to fb22e37 Compare April 18, 2025 12:11
@nalajcie nalajcie requested a review from ziemleszcz April 23, 2025 08:58
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1024 branch from fb22e37 to 5fa5e7e Compare April 23, 2025 09:51
ziemleszcz
ziemleszcz reviewed Apr 24, 2025
View reviewed changes
ziemleszcz
ziemleszcz reviewed Apr 24, 2025
View reviewed changes
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1024 branch from 5fa5e7e to 1934a8f Compare April 24, 2025 15:40
@adamgreloch adamgreloch requested a review from ziemleszcz April 24, 2025 15:40
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1024 branch from 1934a8f to c35da58 Compare April 25, 2025 13:55
ziemleszcz
ziemleszcz reviewed Apr 25, 2025
View reviewed changes
libusb/include/usbdriver.h Outdated
#include <posix/idtree.h>

#define USB_DRVNAME_MAX 10
#define USB_DEVPATH_MAX 32 /* intentionally not using PATH_MAX, as we expect devices from /dev */
Copy link
Contributor

@ziemleszcz ziemleszcz Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this being used anywhere.

Copy link
Contributor

@ziemleszcz ziemleszcz Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I think the idea was to use this for devPath in this repo and path in USB device drivers.

ziemleszcz
ziemleszcz reviewed Apr 25, 2025
View reviewed changes
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1024 branch 3 times, most recently from ef8983b to 31e2379 Compare April 25, 2025 15:42
@adamgreloch adamgreloch requested a review from ziemleszcz April 25, 2025 15:42
ziemleszcz
ziemleszcz reviewed Apr 28, 2025
View reviewed changes
@adamgreloch
usb: pass device insertion result from driver to usbhost
7d50f9a 
Drivers can now return some useful information back to the usbhost about
the state of inserted device

JIRA: RTOS-1024
@adamgreloch
libusb: move external headers to include dir
eff962b 
JIRA: RTOS-1024
@adamgreloch
unify libusb/usb log prints
fe704e7 
JIRA: RTOS-1024
@adamgreloch
usb/usb: replace USB_INTERNAL_ONLY ifdefs to always create /dev/usb
9eef8de 
JIRA: RTOS-1024
@adamgreloch
libusb: fix driver name passing if using procdriver
0a0bc8e 
JIRA: RTOS-1024
@adamgreloch
usb: preserve utf16 value of string descriptors
4884fdb 
Some devices store information in device descriptors in ASCII (even
though string descriptors are to be treated as UTF16 per USB spec...),
in which case converting from UTF16 to ASCII no matter what would cause
loss of information

JIRA: RTOS-1024
@adamgreloch
dev: print vid:pid on device insertion
c1eba41 
JIRA: RTOS-1024
@adamgreloch
usb/drv: fix drivers not being bound to all possible dev interfaces
e1b6dab 
Multifunction (multi-interface) devices may be served by multiple drivers

JIRA: RTOS-1024
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1024 branch from 31e2379 to 00f6411 Compare April 29, 2025 12:00
@adamgreloch adamgreloch requested a review from ziemleszcz April 29, 2025 12:01
ziemleszcz
ziemleszcz previously approved these changes May 14, 2025
View reviewed changes
Darchiv
Darchiv reviewed May 14, 2025
View reviewed changes
@adamgreloch
usb: add device info retrieval API based on driver's device file oid
31b12c7 
The usbhost now also creates symlinks to these driver devices named
`/dev/usb-<vid>-<pid>-if<ifnum>" that can be looked up on and resolved
via `canonicalize_file_name(path)` to acquire the needed oid.

JIRA: RTOS-1024
@adamgreloch
usb/drv: reset msg before each msgSend
d8e07db 
Not resetting caused subsequent msgSend calls to send the modified and
incorrect messages

JIRA: RTOS-1024
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-1024 branch from 00f6411 to d8e07db Compare May 15, 2025 11:21
@adamgreloch adamgreloch requested a review from Darchiv May 15, 2025 11:21
@adamgreloch adamgreloch merged commit 91853a6 into master May 15, 2025
37 checks passed
@adamgreloch adamgreloch deleted the adamgreloch/RTOS-1024 branch May 15, 2025 11:36
@adamgreloch adamgreloch mentioned this pull request Jun 6, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Darchiv Darchiv Darchiv approved these changes

@ziemleszcz ziemleszcz ziemleszcz left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adamgreloch @Darchiv @ziemleszcz