Skip to content

psh, libc: fix tests after trailing slash handling change #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmaksymowicz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

psh, libc: fix tests after trailing slash handling change #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions libc/misc/stat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,10 +961,6 @@ TEST(stat_errno, enoent)

TEST(stat_errno, enotdir)
{
/* Disabled on Phoenix-RTOS because of #682 issue: https://github.com/phoenix-rtos/phoenix-rtos-project/issues/682*/
#ifdef __phoenix__
TEST_IGNORE_MESSAGE("#682 issue");
#endif
struct stat buffer;

errno = 0;
Expand Down
3 changes: 1 addition & 2 deletions psh/test-touch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,9 @@ def assert_multi_arg(p, path, random_wrapper: TestRandom):


def assert_file_slash(p):
""" in psh touch we do not expect error when touching file/ """
file_path = f'{ROOT_TEST_DIR}/slash_file/'
assert_file_created(p, file_path)
psh.assert_cmd(p, f'touch {file_path}', result='success')
psh.assert_cmd(p, f'touch {file_path}', result='fail', expected=f'psh: failed to touch {file_path}: ENOTDIR')


def assert_created_dir(p):
Expand Down