-
Notifications
You must be signed in to change notification settings - Fork 11
kernel: document threadsinfo modifications #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @oI0ck, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the documentation for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the documentation for the syscalls_threadGetInfo function by detailing its new parameters and flags. The added information is comprehensive and very helpful. I've made a few suggestions to improve grammar and clarity in the new documentation text. Overall, this is a great update.
kernel/syscalls/threads.md
Outdated
| In this mode, `info` is treated as an array of `threadinfo_t`, with amount of element | ||
| specified in `n`. Otherwise, `n` must be set to 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'amount of element' is grammatically incorrect. For clarity, it should be 'the number of elements'.
| In this mode, `info` is treated as an array of `threadinfo_t`, with amount of element | |
| specified in `n`. Otherwise, `n` must be set to 1. | |
| In this mode, `info` is treated as an array of `threadinfo_t`, with the number of elements | |
| specified in `n`. Otherwise, `n` must be set to 1. |
kernel/syscalls/threads.md
Outdated
|
|
||
| - `PH_THREADINFO_NAME` | ||
|
|
||
| Returns threads name in `info.name`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kernel/syscalls/threads.md
Outdated
|
|
||
| Returns threads name in `info.name`. | ||
|
|
||
| The actual length of threads name can be arbitrarily long, however, the returned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kernel/syscalls/threads.md
Outdated
|
|
||
| - `PH_THREADINFO_VMEM` | ||
|
|
||
| Returns amount of mapped virtual memory in queried thread in `info.vmem`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve clarity, I suggest rephrasing this sentence. Using 'the amount of' is more specific, and 'for the queried thread' sounds more natural than 'in queried thread'.
| Returns amount of mapped virtual memory in queried thread in `info.vmem`. | |
| Returns the amount of mapped virtual memory for the queried thread in `info.vmem`. |
kernel/syscalls/threads.md
Outdated
|
|
||
| - `PH_THREADINFO_ALL` | ||
|
|
||
| Returns all queriable attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Causes `threadsinfo` to ignore arguments `n` and `info`, as well as rest of | ||
| `flags` bits and returns amount of present threads in the system at the time | ||
| of invocation in `threadsinfo` return value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph has some grammatical items that make it a bit hard to read. I'd suggest rephrasing it for clarity and correctness.
| Causes `threadsinfo` to ignore arguments `n` and `info`, as well as rest of | |
| `flags` bits and returns amount of present threads in the system at the time | |
| of invocation in `threadsinfo` return value. | |
| Causes `threadsinfo` to ignore the `n` and `info` arguments, as well as the rest of | |
| the `flags` bits. It then returns the number of threads present in the system at the time | |
| of invocation as its return value. |
01da87a to
2ee4225
Compare
JIRA: RTOS-1187
2ee4225 to
1c7cc54
Compare
JIRA: RTOS-1187