Skip to content

Conversation

@damianloew
Copy link
Contributor

@damianloew damianloew commented Jan 29, 2024

Description

add nrf91 multi driver

Motivation and Context

Finalizing the nrf9160 basic port

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (nrf9160-dk).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@damianloew damianloew force-pushed the damianloew/nrf9160_port branch from 8dd6c15 to efd2ab5 Compare January 29, 2024 18:46
@damianloew damianloew requested a review from agkaminski January 29, 2024 18:48
@github-actions
Copy link

github-actions bot commented Jan 29, 2024

Unit Test Results

7 078 tests   - 176   6 364 ✅  - 179   38m 7s ⏱️ -9s
  408 suites ±  0     710 💤  -   1 
    1 files   ±  0       4 ❌ +  4 

For more details on these failures, see this check.

Results for commit 152fddd. ± Comparison against base commit 9a4b231.

This pull request removes 180 and adds 4 tests. Note that renamed tests count towards both.
phoenix-rtos-tests/libc/scanf ‑ host-generic-pc:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.A
phoenix-rtos-tests/libc/scanf ‑ host-generic-pc:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.E
phoenix-rtos-tests/libc/scanf ‑ host-generic-pc:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.F
phoenix-rtos-tests/libc/scanf ‑ host-generic-pc:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.G
phoenix-rtos-tests/libc/scanf ‑ host-generic-pc:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.a
phoenix-rtos-tests/libc/scanf ‑ host-generic-pc:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.e
phoenix-rtos-tests/libc/scanf ‑ host-generic-pc:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.f
phoenix-rtos-tests/libc/scanf ‑ host-generic-pc:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.g
phoenix-rtos-tests/libc/scanf ‑ host-generic-pc:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.inf_nan_a
phoenix-rtos-tests/libc/scanf ‑ host-generic-pc:phoenix-rtos-tests/libc/scanf.stdio_scanf_aefg.inf_nan_e
…
phoenix-rtos-tests/libc/scanf ‑ host-generic-pc:phoenix-rtos-tests/libc/scanf
phoenix-rtos-tests/libc/stdlib ‑ host-generic-pc:phoenix-rtos-tests/libc/stdlib
phoenix-rtos-tests/meterfs/meterfs_allocate ‑ host-generic-pc:phoenix-rtos-tests/meterfs/meterfs_allocate
phoenix-rtos-tests/meterfs/meterfs_writeread ‑ host-generic-pc:phoenix-rtos-tests/meterfs/meterfs_writeread

♻️ This comment has been updated with latest results.

@damianloew damianloew force-pushed the damianloew/nrf9160_port branch 2 times, most recently from ceb88ac to 612f5ef Compare January 30, 2024 20:46
@damianloew damianloew force-pushed the damianloew/nrf9160_port branch from 612f5ef to 74754fc Compare February 9, 2024 16:47
@damianloew damianloew requested a review from agkaminski February 9, 2024 16:50
@damianloew damianloew force-pushed the damianloew/nrf9160_port branch from 74754fc to 1e71b09 Compare February 16, 2024 18:16
@agkaminski agkaminski force-pushed the damianloew/nrf9160_port branch from 1e71b09 to 152fddd Compare March 12, 2024 09:24
@lukileczo
Copy link
Member

I guess traditionally, I've introduced breaking changes through the recent msg API changes, summarized in phoenix-rtos/phoenix-rtos-project#1035 🙃

@agkaminski
Copy link
Member

agkaminski commented Mar 21, 2024

Oh no, we've should've merged this PR straight away

@damianloew
Copy link
Contributor Author

damianloew commented Mar 21, 2024

Oh no, we've should've merged this PR straight away

Don't worry, I can update it. I am currently investigating some issue on this platform and I've missed this approve. I will let you know after an update with msgs there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants