Skip to content

Conversation

@badochov
Copy link

@badochov badochov commented Mar 20, 2025

JIRA: RTOS-1028

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@badochov badochov requested a review from Darchiv March 20, 2025 16:55
@Darchiv Darchiv requested a review from nalajcie March 21, 2025 09:05
@badochov badochov force-pushed the badochov/multilib branch from 648e079 to 7de8546 Compare March 21, 2025 10:08
@badochov badochov force-pushed the badochov/multilib branch from 7de8546 to 69832cb Compare March 21, 2025 11:53
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, I'm just making sure I understand how it will work now

@badochov badochov force-pushed the badochov/multilib branch from 69832cb to a36c3d3 Compare March 24, 2025 14:03
nalajcie
nalajcie previously approved these changes Mar 24, 2025
Base automatically changed from badochov/gcc-14.2 to master March 26, 2025 14:55
@badochov badochov dismissed nalajcie’s stale review March 26, 2025 14:55

The base branch was changed.

@badochov badochov force-pushed the badochov/multilib branch from a36c3d3 to f97b037 Compare March 26, 2025 19:12
+PHOENIX_OPTS += /fPIC/mfdpic
+
+# Finally, add Phoenix options to RM multilibs.
+# Keep the orignal requires because of kernel and plo.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[codespell] reported by reviewdog 🐶
orignal ==> original

@@ -1,13 +0,0 @@
-# PhoenixRTOS uses relocatable ELFs on NOMMU platforms
-# if this is ARM Cortex-M/R subvariant -> build libgcc/crtstuff with PIC
-# ALSO: ensure data is not interwined with .text, otherwise running XIP programs would fail

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[codespell] reported by reviewdog 🐶
interwined ==> intertwined

@github-actions
Copy link

github-actions bot commented Mar 26, 2025

Unit Test Results

7 010 tests   - 948   6 551 ✅  - 883   34m 42s ⏱️ - 5m 57s
  412 suites  -  58     459 💤  -  65 
    1 files   ±  0       0 ❌ ±  0 

Results for commit 4f880dc. ± Comparison against base commit 06a6db3.

This pull request removes 948 tests.
flash ‑ armv7a9-zynq7000-zedboard:flash
phoenix-rtos-tests/cpp/hello-cpp ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/cpp/hello-cpp
phoenix-rtos-tests/initfini/main ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/initfini/main
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.in_val
…

♻️ This comment has been updated with latest results.

@badochov badochov requested a review from nalajcie March 26, 2025 19:29
@badochov badochov force-pushed the badochov/multilib branch 2 times, most recently from 4136223 to d7694dd Compare March 27, 2025 08:36
@badochov badochov force-pushed the badochov/multilib branch from d7694dd to 4f880dc Compare March 27, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants