signal: fix sigaction temporary unmasking other signals

[etiaro]

Description

Resolves phoenix-rtos/phoenix-rtos-project#1367
JIRA: RTOS-1097

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

• Already covered by automatic testing.
• New test added: libc: add more signal tests phoenix-rtos-tests#410
• Tested by hand on: ia32-generic-qemu

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing linter checks and tests passed.
• My changes generate no new compilation warnings for any of the targets.

Special treatment

• This PR needs additional PRs to work (list the PRs, preferably in merge-order).
• I will merge this PR by myself when appropriate.

[gemini-code-assist]

Summary of Changes

Hello @etiaro, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've addressed a critical bug in the signal handling mechanism where the sigaction function was inadvertently unmasking other signals due to an incorrect argument order in the signalMask function calls. This fix ensures that signal masking behaves as expected, preventing unintended signal delivery and improving the robustness of the system's signal management.

Highlights

• Fixing signal() function's signal mask: I have corrected the argument order for the signalMask function call within the signal() function. Previously, the newmask and oldmask parameters were inverted, leading to incorrect signal unmasking.
• Fixing sigaction() function's signal mask: I have also corrected the argument order for the signalMask function call within the sigaction() function, addressing the same issue of inverted newmask and oldmask parameters.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes a critical bug in signal() and sigaction() where changing a signal handler would temporarily unmask all other signals, potentially leading to race conditions. The fix correctly adjusts the call to signalMask to only mask the specific signal being handled, rather than replacing the entire signal mask. My review includes suggestions to improve code portability and clarity by replacing a magic number with a more type-safe equivalent.

[github-actions]

Unit Test Results

8 201 tests  +384   7 677 ✅ +362   41m 25s ⏱️ -22s
  479 suites ±  0     524 💤 + 34 
    1 files   ±  0       0 ❌  -  12 

Results for commit a89e104. ± Comparison against base commit edbda70.

This pull request removes 10 and adds 394 tests. Note that renamed tests count towards both.

phoenix-rtos-tests/libc/math ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/math
phoenix-rtos-tests/libc/scanf-advanced ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/scanf-advanced
phoenix-rtos-tests/libc/signal ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/signal
phoenix-rtos-tests/libc/stdio ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/stdio
phoenix-rtos-tests/libc/string ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/string
phoenix-rtos-tests/libc/time ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/time
phoenix-rtos-tests/libuuid/unit ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libuuid/unit
phoenix-rtos-tests/proc/test_thread_rand ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/proc/test_thread_rand
phoenix-rtos-tests/setjmp/unit ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/setjmp/unit
phoenix-rtos-tests/sys/cond ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/sys/cond

phoenix-rtos-tests/libc/math ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/math.math_abs.fabs_basic
phoenix-rtos-tests/libc/math ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/math.math_abs.fabs_max_min
phoenix-rtos-tests/libc/math ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/math.math_abs.fabs_special_cond
phoenix-rtos-tests/libc/math ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/math.math_exp.exp_basic
phoenix-rtos-tests/libc/math ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/math.math_exp.exp_special_cond
phoenix-rtos-tests/libc/math ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/math.math_exp.frexp_basic
phoenix-rtos-tests/libc/math ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/math.math_exp.frexp_special_cond
phoenix-rtos-tests/libc/math ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/math.math_exp.ldexp_basic
phoenix-rtos-tests/libc/math ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/math.math_exp.ldexp_special_cond
phoenix-rtos-tests/libc/math ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/libc/math.math_exp.log10_basic
…

♻️ This comment has been updated with latest results.