Skip to content

Conversation

@bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented May 8, 2023

Congrats again on 0.4.3! 🎉

This brings in some of the patches needed to get the conda-forge package building (and testing) for {linux,win,osx} x py3{8,9,10}:

  • line ending normalization to UNIX-style
  • removing some of the complexity around tests for as-installed-from-source packages
  • normalize invoking python -m pip, etc. (some of the GHA runners get confused)
  • including the .js in the sdist

I've also added MacOS and Windows to the CI matrix, demonstrating the issues I've seen on python 3.11.

I don't know very much about cython (much less on proprietary formats) but figured it would be worth it to demonstrate these here. I tried adding the language_level directive, and that reduced the warning some, but did not fix the underlying issue: even commenting out the the first failing test, we're still seeing segfaults during test. There might be some things to run pytest to get better segfault information, not really sure.

I don't really know how to proceed, but figured it was worth it bringing these up with concrete log outputs.

Thanks again!

@bollwyvl
Copy link
Contributor Author

Refreshed this with 3.12: weirdly, the segfaults still occur on 3.11, but the 3.12rc works fine.

@phith0n
Copy link
Owner

phith0n commented Sep 26, 2023

Indeed a very confused result.

@phith0n
Copy link
Owner

phith0n commented Apr 2, 2025

Refreshed this with 3.12: weirdly, the segfaults still occur on 3.11, but the 3.12rc works fine.

Already make pyduktape2 compitible with Python 3.11, 3.12 and 3.13.
Can you try it again?

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Apr 2, 2025

Thanks for the update.

In taking a look on conda-forge:

I'll probably ship anyway, without those os/python pairs: better than nothing, or shipping known-broken stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants