-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An error handling for division by zero was added by throwing IllegalA… #261
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,35 +3,49 @@ | |
public class Division { | ||
|
||
public static final long division(int a, int b) { | ||
if (b == 0){ | ||
throw now IllegalArgumentException ("Denominator is 0."); | ||
} | ||
|
||
long result = ((long) a) / ((long) b); | ||
|
||
return result; | ||
} | ||
|
||
public static final long divisionUsingLoop(int a, int b) { | ||
int absA = Math.abs(a); | ||
int absB = Math.abs(b); | ||
|
||
if (b == 0){ | ||
throw now IllegalArgumentException ("Denominator is 0."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checks if denominator is 0 before the rest of the division process is complete. |
||
} | ||
|
||
long temp = absA; | ||
long result = 0; | ||
while (temp >= 0) { | ||
temp -= absB; | ||
if (temp >= 0) | ||
result++; | ||
} | ||
} | ||
|
||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
} | ||
|
||
public static final long divisionUsingRecursion(int a, int b) { | ||
int absA = Math.abs(a); | ||
int absB = Math.abs(b); | ||
|
||
if (b == 0){ | ||
throw now IllegalArgumentException ("Denominator is 0."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checks if denominator is 0 before the rest of the division process is complete. |
||
} | ||
|
||
long result = 1; | ||
int diff = absA - absB; | ||
if (diff > 0 && diff <= 1) { | ||
return result; | ||
} else if (diff < 0) { | ||
} else if (diff < 0) { | ||
return 0; | ||
} | ||
} | ||
|
||
result += divisionUsingRecursion(diff, absB); | ||
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result; | ||
|
@@ -41,6 +55,10 @@ public static final long divisionUsingMultiplication(int a, int b) { | |
int absA = Math.abs(a); | ||
int absB = Math.abs(b); | ||
|
||
if(b == 0){ | ||
throw now IllegalArgumentException ("Denominator is 0."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checks if denominator is 0 before the rest of the division process is complete. |
||
} | ||
|
||
int temp = absB; | ||
int counter = 0; | ||
while (temp <= absA) { | ||
|
@@ -59,6 +77,10 @@ public static final long divisionUsingShift(int a, int b) { | |
int absB = Math.abs(b); | ||
int tempA, tempB, counter; | ||
|
||
if(b == 0){ | ||
throw now IllegalArgumentException ("Denominator is 0."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checks if denominator is 0 before the rest of the division process is complete. |
||
} | ||
|
||
long result = 0L; | ||
while (absA >= absB) { | ||
tempA = absA >> 1; // Right shift "a" | ||
|
@@ -78,6 +100,11 @@ public static final long divisionUsingShift(int a, int b) { | |
public static final long divisionUsingLogs(int a, int b) { | ||
long absA = Math.abs(a); | ||
long absB = Math.abs(b); | ||
|
||
if(b == 0){ | ||
throw now IllegalArgumentException ("Denominator is 0."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checks if denominator is 0 before the rest of the division process is complete. |
||
} | ||
|
||
double logBase10A = Math.log10(absA); | ||
double logBase10B = Math.log10(absB); | ||
double powOf10 = Math.pow(10, (logBase10A - logBase10B)); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alerting user the denominator is zero.