Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add commands for set proxy in FF #4549

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

klim-iv
Copy link

@klim-iv klim-iv commented Oct 2, 2024

Commands:
'sn' -> none proxy
'ss' -> system proxy
'sa' -> autodetect proxy
'sm' -> manual proxy

Description

Provide a rationale for this PR, and a reference to the corresponding issue, if there is one.

Please review the "Which pull requests get merged?" section in CONTRIBUTING.md.

Commands:
  'sn' -> none proxy
  'ss' -> system proxy
  'sa' -> autodetect proxy
  'sm' -> manual proxy
@philc
Copy link
Owner

philc commented Jan 4, 2025

I'm curious, what's your use case for having these commands exposed in Vimium? How often do you switch proxies?

@klim-iv
Copy link
Author

klim-iv commented Jan 9, 2025

I'm curious, what's your use case for having these commands exposed in Vimium? How often do you switch proxies?

due to government restrictions in our country some sites can't be opened without foreign proxies, that's why I want to use quick switch for open such sites and update info in tabs. And 'yes' - I do it often :-) , especially to news sites

@philg-dev
Copy link

Wouldn't it make much more sense to use an addon specifically designed for proxy switching, e.g. FoxyProxy, instead and configure URL patterns accordingly? That way you could have FoxyProxy automatically select the proxy you need for any frequently used site. I know it's not exactly the same as having a "shortcut" for open an arbitrary URL with a given proxy, but in the past when I had to use a bunch of proxies for work related stuff FoxyProxy came in extremely handy for like 99% of what I did.

@klim-iv
Copy link
Author

klim-iv commented Jan 12, 2025

Wouldn't it make much more sense to use an addon specifically designed for proxy switching, e.g. FoxyProxy, instead and configure URL patterns accordingly? That way you could have FoxyProxy automatically select the proxy you need for any frequently used site. I know it's not exactly the same as having a "shortcut" for open an arbitrary URL with a given proxy, but in the past when I had to use a bunch of proxies for work related stuff FoxyProxy came in extremely handy for like 99% of what I did.

Yes, I used FoxyProxy, but this is one more plugin with additional configs and etc. As for me - using shortcuts for change proxies is more simplest.
Ok, if you think that such shortcut is excess - I'll close request and will use it privately :-)

@philg-dev
Copy link

Ok, if you think that such shortcut is excess - I'll close request and will use it privately :-)

That's not necessarily what I wanted to say. I was just curious, if FoxyProxy would solve your use case entirely already or if there's further reason to have proxy shortcuts like you've described. I was just trying to add to the discussion and see if you're familiar with proxy switchers.

I'm not the Vimium Owner, so it's not for me to say if it's "excess" or not. Maybe the maintainers like your changes after all 👍 I don't have a strong opinion on it. I think you should leave the pull request open until more people give their opinions / feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants