Skip to content

Conversation

@rileywilddog
Copy link
Contributor

@rileywilddog rileywilddog commented Jul 21, 2023

Search completions are clearly useful enough to be a mainline feature, but the maintainer does not want to expand its usefulness by adding more providers. This PR allows users to benefit from the feature with more than the handful of built-in completion providers.

Adds the following tested examples:

rs: https://runescape.wiki/?search=%s @https://runescape.wiki/api.php?action=opensearch&format=json&search=%s Runescape Wiki
os: https://oldschool.runescape.wiki/?search=%s @https://oldschool.runescape.wiki/api.php?action=opensearch&format=json&search=%s Old School Runescape wiki
man: https://www.mankier.com/?q=%s @https://www.mankier.com/api/v2/suggest/?q=%s@results.*.text ManKier Man Pages

Fixes #4281, opened in case this PR is also rejected.
Mitigates the following closed or ignored PRs/issues to add engines:
#2590 #3851 #3981 #4091 #4094 #4189 #4238

@micangl
Copy link

micangl commented Oct 12, 2023

@philc is there a chance for this PR to be merged before the next release? Currently, the only way to have custom search completion is by patching the source code.

@ojsef39
Copy link

ojsef39 commented Sep 1, 2025

would love to see this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Custom search completion providers

3 participants