Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g$ does not work #1411

Open
raine opened this issue Jan 5, 2015 · 9 comments
Open

g$ does not work #1411

raine opened this issue Jan 5, 2015 · 9 comments

Comments

@raine
Copy link

raine commented Jan 5, 2015

g0 works for me, g$ on the other hand does nothing.

Any idea how to debug this?

@mrmr1993
Copy link
Contributor

mrmr1993 commented Jan 5, 2015

The output of the background page console would be really helpful for this. To get at that

  • go to chrome://extensions
  • enable developer mode (if you haven't already) by checking the checkbox at the top
  • click the "Inspect views: background page" link under Vimium in the extensions page
  • click the show/hide drawer button (second from the right in the top right corner) if it's not already blue
  • select the console tab in the bottom-most pane (the 'drawer')
  • press the leftmost button underneath the console tab. (This clears the console.)

Then you can try g$ and the background page should give some (hopefully useful) information about what's happening.

@raine
Copy link
Author

raine commented Jan 5, 2015

Thanks. Here's the output for g0 and g$, respectively.

checking keyQueue: [ g ]
main.js:722 new KeyQueue: 1g
main.js:720 checking keyQueue: [ 1g0 ]
main.js:722 new KeyQueue: 
main.js:720 checking keyQueue: [ g ]
main.js:722 new KeyQueue: 1g
main.js:720 checking keyQueue: [ 1g<a-4> ]
main.js:722 new KeyQueue: 
main.js:720 checking keyQueue: [ $ ]
main.js:722 new KeyQueue:

@mrmr1993
Copy link
Contributor

mrmr1993 commented Jan 5, 2015

Looks like our code is picking up alt-4 when you press the $ key. Do you use alt-shift-4 for a dollar sign?

@raine
Copy link
Author

raine commented Jan 5, 2015

I'm on Mac, and press option-4 for dollar sign.

@mrmr1993
Copy link
Contributor

mrmr1993 commented Jan 5, 2015

Seems like we don't detect when the option key results in a printing character. I don't have a Mac, so I can only suggest workarounds:

  • Use shift-4 instead of option-4 (assuming that also gives a dollar symbol).
  • Map another key combo to the command and use that.

Sorry I couldn't be more help!

@philc
Copy link
Owner

philc commented Jan 6, 2015

How are you getting option-4 to result in a $ character? I'm on a mac and
must use shift.

On Mon, Jan 5, 2015 at 2:05 PM, Matthew Ryan [email protected]
wrote:

Seems like we don't detect when the option key results in a printing
character. I don't have a Mac, so I can only suggest workarounds:

  • Use shift-4 instead of option-4 (assuming that also gives a dollar
    symbol).
  • Map another key combo to the command and use that.

Sorry I couldn't be more help!


Reply to this email directly or view it on GitHub
#1411 (comment).

@raine
Copy link
Author

raine commented Jan 6, 2015

Well, I have a different layout. shift-4 is euro sign € for me.

No problems in vim, mind you.

@maximbaz
Copy link

maximbaz commented Jan 6, 2015

This issue is not OS-specific, and it is true that some (how many?) European keyboard layouts have another character assigned to Shift+4.

Testing on Windows, with Danish keyboard:
Shift+4 => ¤
AltGr+4 => $ // AltGr is a special key, which is essentially the same as holding Ctrl+Atl together.

With that, g$ (g<AltGr+4>) doesn't work for me either.
I'm testing the WebStore version, soon can try on master as well, just to be sure.

P.S. It's time to introduce a label for "international" issues, this and #1387 are the candidates 😄

@mrmr1993
Copy link
Contributor

mrmr1993 commented Jan 7, 2015

We should keep an eye on Chromium issue 227231: when it gets resolved, this should be an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants