Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift-modified number keys aren't passed to the page even if we don't handle them #1417

Closed
mrmr1993 opened this issue Jan 7, 2015 · 2 comments

Comments

@mrmr1993
Copy link
Contributor

mrmr1993 commented Jan 7, 2015

Currently KeyboardUtils.getKeyChar doesn't check the shiftKey attribute of the key event for number keys, so it returns 1 for !, 2 for ", etc. We end up blocking these keys that we will never handle ourselves based on this wrong information. This also means that our g$ mapping working is a complete fluke; we accept $ because we want to handle 4.

This is closely related to #1411. Chromium issue 227231 should make all this pain go away.

@dragon788
Copy link

This makes me really sad, because I have been throwing all the Gmail special
characters for managing my email into my .vimiumrc and was wondering why # wasn't working for delete and @ didn't work for archiving.

@mrmr1993
Copy link
Contributor Author

Chromium issue 22731 did indeed make all this pain go away. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants