Added tests for notification API and dialog element #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had written a small program that utilized the HTML5 Notification API a while back and had made some has.js tests to do feature detection. I had written them as an AMD module, but rewrote them to be more like the other detect scripts and wanted to contribute them to the project.
I was also playing around with the dialog element the other day and wanted to write a feature detect for that as well since, as of right now, it's only supported in Chrome. Is this the correct way to contribute tests?
Also, there doesn't seem to be much commenting in the other scripts so I left my comments out. Is this correct?