-
-
Notifications
You must be signed in to change notification settings - Fork 4
fix: adds support for nested groups #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment in the reviewed file, thank you.
@@ -1,10 +1,8 @@ | |||
{ | |||
"compilerOptions": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these lines removed? Could you explain what the reason is behind it without me having to figure it out on my own? Thank you :)
Can we merge this after review please? This is a very good addition .. This also closes both the issues as they seem to relate to what the author of this PR fixed. Edit: Why is this PR not merged yet? Maybe issues that need to be resolved? |
@codeit-ninja Unfortunately, this hits the limit of what typescript can handle in terms of nested types. Will need to look into flattening some of the structures there but it's a little complicated to get right. |
@phenax It seems to work correctly in my project, I dont hit any limitations? It correctly shows optional groups, in the picture |
@codeit-ninja it works for some expressions but there are a lot of cases where ts errors out |
@phenax Thats odd, I dont get this warning/error What TS version are you using? I am on |
WIP. Will need to re-write the parser to work better with nested groups without nesting the types to its limits