Skip to content

Copy folder recursive API for fs native #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Copy folder recursive API for fs native #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/phoenix/fslib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ const fileSystemLib = {
}
return filerShell.rm(path, { recursive: true }, cb);
},
copyFile: function (src, dst, callback) {
copy: function (src, dst, callback) {
if(Mounts.isMountSubPath(src) && Mounts.isMountSubPath(dst)) {
return NativeFS.copyFile(src, dst, callback);
return NativeFS.copy(src, dst, callback);
}
throw new Errors.ENOSYS('Phoenix fs copy on filer or across filer and native not yet supported');
},
Expand Down
102 changes: 83 additions & 19 deletions src/phoenix/fslib_native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,30 @@ import Constants from "./constants.js";
import Utils from "./utils.js";


async function listDir(handle, callback) {
async function _listDir(handle, callback) {
let dirEntryNames = [];
for await (const [key] of handle.entries()) {
dirEntryNames.push(key);
}
callback(null, dirEntryNames);
if(callback){
callback(null, dirEntryNames);
}
return dirEntryNames;
}


async function _mkdir(paretDirHandle, dirName, callback) {
try {
await paretDirHandle.getDirectoryHandle(dirName, { create: true });
callback(null);
let childDirHandle = await paretDirHandle.getDirectoryHandle(dirName, { create: true });
if(callback){
callback(null);
}
return childDirHandle;
} catch (e) {
callback(new Errors.EIO('Filer native fs function not yet supported.', e));
if(callback){
callback(new Errors.EIO('Filer native fs function not yet supported.', e));
}
throw new Errors.EIO('Filer native fs function not yet supported.', e);
}
}

Expand Down Expand Up @@ -88,7 +97,7 @@ function readdir(path, options, callback) {
} else if (handle.kind === Constants.KIND_FILE) {
callback(new Errors.ENOTDIR('Path is not a directory.'));
}else {
listDir(handle, callback);
_listDir(handle, callback);
}
});
}
Expand Down Expand Up @@ -216,50 +225,105 @@ async function unlink(path, callback) {
});
}

async function _getDestinationFileHandle(dst, srcFileName) {
async function _getDestinationHandle(dst, srcBaseName, handleKindToCreate) {
return new Promise(async (resolve, reject) => {
dst = window.path.normalize(dst);
let dirPath= window.path.dirname(dst);
let dstFileName= window.path.basename(dst);
let dstBaseName= window.path.basename(dst);
let dstHandle = await Mounts.getHandleFromPathIfPresent(dst);
let dstParentHandle = await Mounts.getHandleFromPathIfPresent(dirPath);
if (dstHandle && dstHandle.kind === Constants.KIND_FILE) {
reject(new Errors.EEXIST(`Copy file destination already exists: ${dst}`));
} else if (dstHandle && dstHandle.kind === Constants.KIND_DIRECTORY) {
const fileHandle = await dstHandle.getFileHandle(srcFileName, {create: true});
reject(new Errors.EEXIST(`Destination file already exists: ${dst}`));
} else if (dstHandle && dstHandle.kind === Constants.KIND_DIRECTORY
&& handleKindToCreate === Constants.KIND_FILE) {
const fileHandle = await dstHandle.getFileHandle(srcBaseName, {create: true});
resolve(fileHandle);
} else if (!dstHandle && dstParentHandle && dstParentHandle.kind === Constants.KIND_DIRECTORY) {
const fileHandle = await dstParentHandle.getFileHandle(dstFileName, {create: true});
} else if (dstHandle && dstHandle.kind === Constants.KIND_DIRECTORY
&& handleKindToCreate === Constants.KIND_DIRECTORY) {
let dstChildHandle = await Mounts.getHandleFromPathIfPresent(`${dst}/${srcBaseName}`);
if(dstChildHandle){
reject(new Errors.EEXIST(`Copy destination already exists: ${dst}/${srcBaseName}`));
return;
}
const directoryHandle = await dstHandle.getDirectoryHandle(srcBaseName, {create: true});
resolve(directoryHandle);
} else if (!dstHandle && dstParentHandle && dstParentHandle.kind === Constants.KIND_DIRECTORY
&& handleKindToCreate === Constants.KIND_FILE) {
const fileHandle = await dstParentHandle.getFileHandle(dstBaseName, {create: true});
resolve(fileHandle);
} else if (!dstHandle && dstParentHandle && dstParentHandle.kind === Constants.KIND_DIRECTORY
&& handleKindToCreate === Constants.KIND_DIRECTORY) {
const fileHandle = await dstParentHandle.getDirectoryHandle(dstBaseName, {create: true});
resolve(fileHandle);
} else {
reject(new Errors.ENOENT(`Copy destination doesnt exist: ${dst}`));
}
});
}

async function _copyFile(srcFileHandle, dst, srcFileName, callback) {
async function _copyFileFromHandles(srcFileHandle, dstHandle, optionalName) {
// TODO Add retry mechanisms when copying large folders
try {
let dstHandle = await _getDestinationFileHandle(dst, srcFileName);
if(optionalName){
dstHandle = await dstHandle.getFileHandle(optionalName, {create: true});
}
const srcFile = await srcFileHandle.getFile();
const srcStream = await srcFile.stream();
const writable = await dstHandle.createWritable();
await srcStream.pipeTo(writable);
} catch (e) {
console.error(`Error while copying ${dstHandle.name}/${optionalName} : ${e}`);
throw e;
}
}

async function _copyFileWithHandle(srcFileHandle, dst, srcFileName, callback) {
try {
let dstHandle = await _getDestinationHandle(dst, srcFileName, Constants.KIND_FILE);
await _copyFileFromHandles(srcFileHandle, dstHandle);
callback();
} catch (e) {
callback(e);
}
}

async function _treeCopy(srcFolderHandle, dstFolderHandle, recursive) {
let allDonePromises = [];
for await (const [key, srcHandle] of srcFolderHandle.entries()) {
if (srcHandle.kind === Constants.KIND_FILE) {
allDonePromises.push(_copyFileFromHandles(srcHandle, dstFolderHandle, key));
} else if (srcHandle.kind === Constants.KIND_DIRECTORY) {
const childDirHandle = await _mkdir(dstFolderHandle, key);
if(recursive && childDirHandle){
allDonePromises.push(_treeCopy(srcHandle, childDirHandle, recursive));
}
}
}
await Promise.all(allDonePromises);
}

async function _copyFolderWithHandle(srcFolderHandle, dst, srcFileName, callback, recursive) {
try {
let dstFolderHandle = await _getDestinationHandle(dst, srcFileName, Constants.KIND_DIRECTORY);
await _treeCopy(srcFolderHandle, dstFolderHandle, recursive);
callback();
} catch (e) {
callback(e);
}
}

async function copyFile(src, dst, callback) {
async function copy(src, dst, callback, recursive = true) {
let srcFile = window.path.normalize(src);
let srcFileName= window.path.basename(srcFile);
Mounts.getHandleFromPath(srcFile, async (err, srcHandle) => {
if(err){
callback(err);
} else if (srcHandle.kind === Constants.KIND_FILE) {
return _copyFileWithHandle(srcHandle, dst, srcFileName, callback);
} else if (srcHandle.kind === Constants.KIND_DIRECTORY) {
callback(new Errors.EISDIR(`Copy file cannot copy directory: ${srcFile}`));
return _copyFolderWithHandle(srcHandle, dst, srcFileName, callback, recursive);
} else {
_copyFile(srcHandle, dst, srcFileName, callback);
callback(new Errors.EIO(`Cannot copy src: ${srcFile}`));
}
});
}
Expand All @@ -281,7 +345,7 @@ const NativeFS = {
readFile,
writeFile,
unlink,
copyFile
copy
};

export default NativeFS;