Skip to content

Understand the before field for Push events #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Understand the before field for Push events #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion hookserve/hookserve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ import (
"crypto/sha1"
"encoding/hex"
"errors"
"github.com/bmatsuo/go-jsontree"
"io/ioutil"
"net/http"
"strconv"
"strings"

jsontree "github.com/bmatsuo/go-jsontree"
)

var ErrInvalidEventFormat = errors.New("Unable to parse event string. Invalid Format.")
Expand All @@ -20,6 +21,7 @@ type Event struct {
Branch string // The branch the event took place on
Commit string // The head commit hash attached to the event
Type string // Can be either "pull_request" or "push"
Before string // For Pushes, contains the SHA of the recent commit on Branch before the push.
Action string // For Pull Requests, contains "assigned", "unassigned", "labeled", "unlabeled", "opened", "closed", "reopened", or "synchronize".
BaseOwner string // For Pull Requests, contains the base owner
BaseRepo string // For Pull Requests, contains the base repo
Expand Down Expand Up @@ -67,6 +69,9 @@ func NewEvent(e string) (*Event, error) {
return nil, ErrInvalidEventFormat
}
}
if event.Type == "push" && len(parts) == 6 {
event.Before = parts[5][8:]
}

return &event, nil
}
Expand All @@ -84,6 +89,9 @@ func (e *Event) String() (output string) {
output += "brepo: " + e.BaseRepo + "\n"
output += "bbranch:" + e.BaseBranch + "\n"
}
if e.Type == "push" {
output += "before: " + e.Before + "\n"
}

return
}
Expand Down Expand Up @@ -219,6 +227,12 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, req *http.Request) {
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
event.Before, err = request.Get("before").String()
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}

} else if eventType == "pull_request" {
event.Action, err = request.Get("action").String()
if err != nil {
Expand Down