10.8 #955
10.8 #955
Conversation
| Drupal: true, | ||
| jQuery: true, | ||
| _: true, | ||
| // _: true, |
jryanconklin
left a comment
jryanconklin
left a comment
There was a problem hiding this comment.
There’s an empty spacing.json file. Beyond that it’s worth noting this approach will break Octane scripts, which now is configured to separate the theme, module, and particle into separate directories. Considering the priority of the Octane project, I wouldn’t expect this to be changed until the New Year.
| path: APP_DIST, | ||
| publicPath: APP_DIST_PUBLIC, | ||
| // Output all CSS/JS/images/twig to dist/ within drupal theme | ||
| path: path.resolve(__dirname, 'particle_theme/dist'), |
There was a problem hiding this comment.
Octane programmatically moves this directory.
| const { NODE_ENV, PARTICLE_PL_HOST = '' } = process.env; | ||
| // Constants: root | ||
| const { PATTERN_LAB_DIST } = require('../../particle.root.config'); | ||
| const { PATH_DIST } = require('../../particle.root.config'); |
There was a problem hiding this comment.
Are we undoing having particle split out from the Drupal theme?
| module.exports = ({ options, env }) => { | ||
| const tailWindPath = path.resolve( | ||
| __dirname, | ||
| './source/default/tailwind.config.js' |
There was a problem hiding this comment.
This might be nice to set up as config since default may not survive as a name.
| }, | ||
| variants: {}, | ||
| plugins: [tailwindCustomForms], | ||
| future: { |
There was a problem hiding this comment.
Might be worth a comment here that future can be removed in Tailwind 2.0
No description provided.