Skip to content

eslint-setup: Adds logic to create simplified eslintrc.js file. #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: eleven
Choose a base branch
from
Open

eslint-setup: Adds logic to create simplified eslintrc.js file. #942

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b52606e
eslint-setup: Adds logic to create simplified eslintrc.js file.
IMGoodrich Aug 18, 2020
e48dc7f
Update packages/generator-particle-base/src/generators/app/index.ts
LeeMellon Aug 18, 2020
07c997f
eslint-setup: minor cleanup.
IMGoodrich Aug 18, 2020
72c14b1
eslint-setup: Remove refs to index.js in supplemental eslint-config f…
IMGoodrich Aug 18, 2020
1055804
eslint-setup: Cleanup formatting and add minor docs.
IMGoodrich Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/generator-particle-base/src/generators/app/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Generator from 'yeoman-generator'
import merge from 'lodash.merge'
import fs from 'fs'
import _ from 'lodash';

import {
Answers,
Expand Down Expand Up @@ -88,6 +89,26 @@ module.exports = class extends Generator {
)
}

/**
* Create eslintrc file
**/

_eslintCompile(configuration: Answers ) {
const {frontendFramework, testingLibraries, hasTypescript } = configuration.options;
const validPackages: string[] = ['react', 'vue', 'cypress', 'jest', 'typescript']
const extend: string[] = [...frontendFramework, ...testingLibraries, hasTypescript ? 'typescript': ''];
const elements: string[] = _.filter(extend, (el)=> validPackages.includes(el)).map(el => `\n'@phase2/eslint-config/${el}'`);

const esModule = `module.exports = {
extends: [
'@phase2/eslint-config', ${elements}
]
}`

fs.writeFileSync(`${process.cwd()}/.eslintrc.js`, esModule)

}

async _promptUser() {
// Initialize storybook
const results: ConfigurationAnswers = await this.prompt(configurationPrompt)
Expand Down Expand Up @@ -115,6 +136,7 @@ module.exports = class extends Generator {
async initializing() {
await this._promptUser()

this._eslintCompile(this.configuration)
// All composed generators must be imported following this syntax https://yeoman.io/authoring/composability.html
if (
this.configuration.options.frontendFramework.includes(
Expand Down